[pulseaudio-discuss] [PATCHv2 05/10] tests: Add remap test code to cpu-test

Peter Meerwald pmeerw at pmeerw.net
Thu Jan 31 22:33:34 PST 2013


> Thanks! I'll apply this soon (along with patches 1-4, the rest I haven't
> yet looked at). A couple of comments:

thank you for considering the patches!

> > + static void run_remap_test_mono_stereo_float(pa_remap_t *remap,
> > +    pa_do_remap_func_t func, pa_do_remap_func_t orig_func,
> > +    int align, pa_bool_t correct, pa_bool_t perf) {
> 
> Wrapped function argument lists are usually formatted like this:
> 
> static void run_remap_test_mono_stereo_float(
>         pa_remap_t *remap,
>         pa_do_remap_func_t func,
>         pa_do_remap_func_t orig_func,
>         int align,
>         pa_bool_t correct,
>         pa_bool_t perf) {
> 
> > +START_TEST (remap_sse_test) {
> 
> The test is for SSE2, so I'll change the test name to remap_sse2_test.

ack!

p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)


More information about the pulseaudio-discuss mailing list