[pulseaudio-discuss] [PATCH 18/56] build: Load the right modules depending on the BlueZ version

[João Paulo Rechi Vita]

On Jul 18, 2013 9:45 AM, "Tanu Kaskinen" <tanu.kaskinen at linux.intel.com>
wrote:
>
> On Fri, 2013-07-12 at 15:06 -0300, jprvita at gmail.com wrote:
> > From: João Paulo Rechi Vita <jprvita at openbossa.org>
> >
> > Support for BlueZ 4 is built only when bluez.pc is present on the target
> > system, and that is a big hint that we should load the BlueZ 4 modules.
> > On all other cases we can try to load the BlueZ 5 modules.
> > ---
> >  src/daemon/default.pa.in | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/daemon/default.pa.in b/src/daemon/default.pa.in
> > index 19dd8a6..9a7fa40 100755
> > --- a/src/daemon/default.pa.in
> > +++ b/src/daemon/default.pa.in
> > @@ -85,15 +85,20 @@ load-module module-jackdbus-detect channels=2
> >  .fail
> >  .endif
> >
> > -ifelse(@HAVE_BLUEZ_4@, 1, [dnl
> >  ### Automatically load driver modules for Bluetooth hardware
> >  .ifexists module-bluetooth-policy at PA_SOEXT@
> >  load-module module-bluetooth-policy
> >  .endif
>
> I think module-bluetooth-policy should be omitted from the configuration
> file if there's no BlueZ support compiled in at all.
>

I did it this way to avoid having another AC variable just to tell if any
BlueZ version is enabled (maybe there is a different way to do it in
autotools that I'm not aware of) and since we already check in the .pa
language for the existence of module-bluetooth-policy.so.

I'll send an updated version and you can comment if there is a better
approach.

--
João Paulo Rechi Vita
http://about.me/jprvita
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20130725/bb6a8a2d/attachment.html>