[pulseaudio-discuss] [PATCH 22/56] bluetooth: Track org.bluez for BlueZ 5

[João Paulo Rechi Vita]

On Jul 18, 2013 10:55 AM, "Tanu Kaskinen" <tanu.kaskinen at linux.intel.com>
wrote:
>
> On Fri, 2013-07-12 at 15:06 -0300, jprvita at gmail.com wrote:
> > From: João Paulo Rechi Vita <jprvita at openbossa.org>
> >
> > ---
> >  src/modules/bluetooth/bluez5-util.c | 101
++++++++++++++++++++++++++++++++++++
> >  1 file changed, 101 insertions(+)
> >
> > diff --git a/src/modules/bluetooth/bluez5-util.c
b/src/modules/bluetooth/bluez5-util.c
>
> > +static DBusHandlerResult filter_cb(DBusConnection *bus, DBusMessage
*m, void *userdata) {
> > +    pa_bluetooth_discovery *y;
> > +    DBusError err;
> > +    const char *path, *interface, *member;
> > +
> > +    pa_assert(bus);
> > +    pa_assert(m);
> > +    pa_assert_se(y = userdata);
> > +
> > +    path = dbus_message_get_path(m);
> > +    interface = dbus_message_get_interface(m);
> > +    member = dbus_message_get_member(m);
> > +
> > +    pa_log_debug("dbus: path=%s, interface=%s, member=%s", path,
interface, member);
>
> I don't like this message, it spams the log with all D-Bus traffic,
> which does more harm than good IMO.
>

I personally like it, but I agree it doesn't scale well as we add more
filter_cb functions (the oFono backend has a new one, for example) and that
dbus-monitor should substitute this line well enough. I'll send an updated
version.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20130725/99b97247/attachment.html>