[pulseaudio-discuss] [pa-ucm] SIGABORT in ucm_get_modifiers

[sajeesh sidharthan]

Hi Tanu,

Thank You for your reply. 

I have checked latest alsa release and I couldnt find any fix done for this.
If modifier is not present, still alsa-ucm returns count as 0 and modifier_list unallocated. Since in PA, modifier list is not initialized, SIGABORT can still happen.

Sajeesh



________________________________
 From: Tanu Kaskinen <tanu.kaskinen at linux.intel.com>
To: sajeesh sidharthan <sajeesh.sidharthan at yahoo.com> 
Cc: "pulseaudio-discuss at lists.freedesktop.org" <pulseaudio-discuss at lists.freedesktop.org> 
Sent: Monday, June 17, 2013 7:01 AM
Subject: Re: [pulseaudio-discuss] [pa-ucm] SIGABORT in ucm_get_modifiers
 

On Mon, 2013-06-17 at 06:12 -0700, sajeesh sidharthan wrote:
> Hello.
> 
> Ths change fixed SIGABORT.
> 
> -----------------
> 
> diff --git a/src/modules/alsa/alsa-ucm.c b/src/modules/alsa/alsa-ucm.c
> index 3b55e82..1156ffa 100644
> --- a/src/modules/alsa/alsa-ucm.c
> +++ b/src/modules/alsa/alsa-ucm.c
> @@ -361,7 +361,7 @@ static int ucm_get_modifier_property(pa_alsa_ucm_modifier *modifier, snd_use_cas
>  
>  /* Create a list of devices for this verb */
>  static int ucm_get_devices(pa_alsa_ucm_verb *verb, snd_use_case_mgr_t *uc_mgr) {
> -    const char **dev_list;
> +    const char **dev_list = NULL;
>      int num_dev, i;
>  
>      num_dev = snd_use_case_get_list(uc_mgr, "_devices", &dev_list);
> @@ -384,7 +384,7 @@ static int ucm_get_devices(pa_alsa_ucm_verb *verb, snd_use_case_mgr_t *uc_mgr) {
>  };
>  
>  static int ucm_get_modifiers(pa_alsa_ucm_verb *verb, snd_use_case_mgr_t *uc_mgr) {
> -    const char **mod_list;
> +    const char **mod_list = NULL;
>      int num_mod, i;
>  
>      num_mod = snd_use_case_get_list(uc_mgr, "_modifiers", &mod_list);

This is a known ALSA bug that has been fixed in alsa-lib 1.0.26, but
thanks for your efforts anyway.

-- 
Tanu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20130617/a61a9720/attachment.html>