[pulseaudio-discuss] [PATCH 06/21] device-manager: Add a sanity check for reading entries

[Tanu Kaskinen]

There is code elsewhere that assumes that if user_set_description is
true, then the description is non-NULL.
---
 src/modules/module-device-manager.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/modules/module-device-manager.c b/src/modules/module-device-manager.c
index 5db5550..57abd06 100644
--- a/src/modules/module-device-manager.c
+++ b/src/modules/module-device-manager.c
@@ -306,6 +306,11 @@ static struct entry* entry_read(struct userdata *u, const char *name) {
         goto fail;
     }
 
+    if (e->user_set_description && !description) {
+        pa_log("Entry has user_set_description set, but the description is NULL.");
+        goto fail;
+    }
+
     e->description = pa_xstrdup(description);
     e->icon = pa_xstrdup(icon);
 
-- 
1.8.1.2