[pulseaudio-discuss] [PATCH 00/21] Add a basic node concept

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Fri Jun 28 00:01:03 PDT 2013


On Wed, 2013-06-19 at 18:39 +0300, Tanu Kaskinen wrote:
> This patch set adds pa_node, pa_port_node, pa_sink_node,
> pa_source_node, pa_sink_input_node and pa_source_output node structs
> to the core. Node support is added for some backends: alsa, bluetooth,
> jack, and native streams. I didn't implement other backends, because
> I'm lazy (a nicer excuse might be that the nodes may evolve quite
> a bit, so there's less code to fix when that happens).
> 
> The nodes aren't yet visible to clients, and the nodes don't support
> any operations to be done on them, such as routing between two nodes.
> I'll try to keep the patch sets small enough not to scare reviewers
> (21 patches is already more than I'd like).
> 
> Tanu Kaskinen (21):
>   device-port: Assert that ports have a description
>   device-class: Introduce pa_device_class_t
>   bluetooth: Use pa_device_class_t
>   alsa: Ensure that sinks and sources have descriptions
>   waveout: Simplify setting the device description
>   device-manager: Add a sanity check for reading entries
>   sink, source: Disallow setting NULL description
>   sink, source: Assert that a description is always set
>   sink, source: Add pa_sink/source_get_description()
>   sink-input, source-output: Add
>     pa_sink_input/source_output_get_description()
>   node: Introduce pa_node
>   sink-node, source-node: Introduce sink and source nodes
>   device-port: Add a device_class field to ports
>   port-node: Introduce pa_port_node
>   dynarray: Reimplement with nicer semantics
>   alsa: Add node support
>   bluetooth: Add node support
>   jack: Add node supprt
>   sink-input-node, source-output-node: Introduce sink input and source
>     output nodes
>   object: Initialize allocated memory to zero
>   native: Add node support for streams

I pushed now two more patches:
 - waveout: Simplify setting the device description
 - device-manager: Add a sanity check for reading entries

The first review round didn't raise concerns about those patches, they
are pretty trivial and I don't want to carry them in v2, since they are
only tangentially related to nodes.

-- 
Tanu



More information about the pulseaudio-discuss mailing list