[pulseaudio-discuss] [PATCH v2 02/18] sink, source: Disallow setting NULL description

[Tanu Kaskinen]

On Fri, 2013-06-28 at 12:59 +0200, David Henningsson wrote:
> On 06/28/2013 09:47 AM, Tanu Kaskinen wrote:
> > ---
> >   src/pulsecore/sink.c   | 15 +++++----------
> >   src/pulsecore/source.c | 13 ++++---------
> >   2 files changed, 9 insertions(+), 19 deletions(-)
> >
> > diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c
> > index cf3a90e..3d039b4 100644
> > --- a/src/pulsecore/sink.c
> > +++ b/src/pulsecore/sink.c
> > @@ -2295,29 +2295,24 @@ pa_bool_t pa_sink_update_proplist(pa_sink *s, pa_update_mode_t mode, pa_proplist
> >   }
> >
> >   /* Called from main thread */
> > -/* FIXME -- this should be dropped and be merged into pa_sink_update_proplist() */
> >   void pa_sink_set_description(pa_sink *s, const char *description) {
> >       const char *old;
> > +
> >       pa_sink_assert_ref(s);
> > +    pa_assert(description);
> 
> Are empty names okay ( description[0] == '\0') ? Otherwise you might 
> want to add that too to your list of assertions.

Yes, that makes sense.

-- 
Tanu