[pulseaudio-discuss] [RFC next v4 02/16] bluetooth: Parse the tree returned by ObjectManager

[Tanu Kaskinen]

On Mon, 2013-04-29 at 18:27 +0200, Mikel Astiz wrote:
> From: Mikel Astiz <mikel.astiz at bmw-carit.de>
> 
> Parse the result of ObjectManager.GetManagedObjects(), which includes
> all objects registered, their interfaces and the corresponding
> properties per interface.
> ---
>  src/modules/bluetooth/bluetooth-util.c | 125 +++++++++++++++++++++++++++++++--
>  1 file changed, 119 insertions(+), 6 deletions(-)

Thanks, I'll apply this with a small style fix, see below.

> +static int parse_device_properties(pa_bluetooth_device *d, DBusMessageIter *i, bool is_property_change) {
> +    DBusMessageIter element_i;
> +    int ret = 0;
> +
> +    dbus_message_iter_recurse(i, &element_i);
> +
> +    while (dbus_message_iter_get_arg_type(&element_i) == DBUS_TYPE_DICT_ENTRY) {
> +        DBusMessageIter dict_i;
> +
> +        dbus_message_iter_recurse(&element_i, &dict_i);
> +
> +        if (parse_device_property(d, &dict_i, is_property_change))

"< 0" should be used in the return value check.

-- 
Tanu

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.