[pulseaudio-discuss] [RFC next v4 08/16] bluetooth: Parse media transport's properties

[João Paulo Rechi Vita]

On Mon, Apr 29, 2013 at 1:28 PM, Mikel Astiz <mikel.astiz.oss at gmail.com> wrote:
> From: Mikel Astiz <mikel.astiz at bmw-carit.de>
>
> Add the code to parse the properties of the media transport object when
> a PropertiesChanged signal is received.
>
> Note that the transport might have an owner other than BlueZ, and thus
> the property changes would be emitted from arbitrary senders. For
> performance reasons, the installed match considers the interface name
> where the property has changed.
>
> It could be possible to install and remove the D-Bus matches dynamically
> when a new owner is registered/unregistered, but filtering based on the
> interface name seems good enough already.
> ---
>  src/modules/bluetooth/bluetooth-util.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/src/modules/bluetooth/bluetooth-util.c b/src/modules/bluetooth/bluetooth-util.c
> index 14bd3ea..871341d 100644
> --- a/src/modules/bluetooth/bluetooth-util.c
> +++ b/src/modules/bluetooth/bluetooth-util.c
> @@ -1094,6 +1094,24 @@ static int transport_parse_property(pa_bluetooth_transport *t, DBusMessageIter *
>      return 0;
>  }
>
> +static int parse_transport_properties(pa_bluetooth_transport *t, DBusMessageIter *i) {
> +    DBusMessageIter element_i;
> +
> +    dbus_message_iter_recurse(i, &element_i);
> +
> +    while (dbus_message_iter_get_arg_type(&element_i) == DBUS_TYPE_DICT_ENTRY) {
> +        DBusMessageIter dict_i;
> +
> +        dbus_message_iter_recurse(&element_i, &dict_i);
> +
> +        transport_parse_property(t, &dict_i);
> +
> +        dbus_message_iter_next(&element_i);
> +    }
> +
> +    return 0;
> +}
> +
>  static DBusHandlerResult filter_cb(DBusConnection *bus, DBusMessage *m, void *userdata) {
>      DBusError err;
>      pa_bluetooth_discovery *y;
> @@ -1311,6 +1329,13 @@ static DBusHandlerResult filter_cb(DBusConnection *bus, DBusMessage *m, void *us
>                  return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; /* Device not being tracked */
>
>              parse_device_properties(d, &arg_i, true);
> +        } else if (pa_streq(interface, "org.bluez.MediaTransport1")) {
> +            pa_bluetooth_transport *t;
> +
> +            if (!(t = pa_hashmap_get(y->transports, dbus_message_get_path(m))))
> +                return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
> +
> +            parse_transport_properties(t, &arg_i);
>          }
>
>          return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
> @@ -1975,6 +2000,8 @@ pa_bluetooth_discovery* pa_bluetooth_discovery_get(pa_core *c) {
>                  "type='signal',sender='org.bluez',interface='org.freedesktop.DBus.ObjectManager',member='InterfacesRemoved'",
>                  "type='signal',sender='org.bluez',interface='org.freedesktop.DBus.Properties',member='PropertiesChanged'"
>                  ",arg0='org.bluez.Device1'",
> +                "type='signal',interface='org.freedesktop.DBus.Properties',member='PropertiesChanged'"
> +                ",arg0='org.bluez.MediaTransport1'",

Same question of patch 4 applies here, why are you not removing this
match on pa_bluetooth_discovery_unref()?

>                  NULL) < 0) {
>          pa_log("Failed to add D-Bus matches: %s", err.message);
>          goto fail;
> --
> 1.8.1.4
>
> _______________________________________________
> pulseaudio-discuss mailing list
> pulseaudio-discuss at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss



--
João Paulo Rechi Vita
http://about.me/jprvita