[pulseaudio-discuss] [PATCH 1/4] card: Ensure we still pick a profile even if it's unavailable.

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Fri Nov 22 01:42:25 PST 2013


On Fri, 2013-11-15 at 09:33 +0100, Colin Guthrie wrote:
> f434087e42b introduced the potential to not select a card profile if
> all the profiles were marked as unavailable.
> 
> While this is very unlikely, it's a theoretical posibility, so if the
> initial choice of a profile fails, try harder.
> ---
>  src/pulsecore/card.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Thanks for the patches! I have now applied patches 1 and 3. I don't
think PA_AVAILABLE_YES should be preferred over PA_AVAILABLE_UNKNOWN, so
I didn't apply 2 and 4.

I guess these patches haven't been tested very much? It would be good to
at least test that the patches compile before submitting them... (Patch
3 didn't compile.)

-- 
Tanu



More information about the pulseaudio-discuss mailing list