[pulseaudio-discuss] [PATCH 1/2] build-sys: Don't define _FORTIFY_SOURCE when building with -O0

[Tanu Kaskinen]

On Mon, 2013-10-14 at 16:38 +0200, David Henningsson wrote:
> On 10/14/2013 04:33 PM, Tanu Kaskinen wrote:
> > On Mon, 2013-10-14 at 15:39 +0200, David Henningsson wrote:
> >> On 10/12/2013 11:51 AM, Tanu Kaskinen wrote:
> >>> ---
> >>>  configure.ac | 7 ++++++-
> >>>  1 file changed, 6 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/configure.ac b/configure.ac
> >>> index 42cb8b8..e2465e4 100644
> >>> --- a/configure.ac
> >>> +++ b/configure.ac
> >>> @@ -165,12 +165,17 @@ esac
> >>>  #### Compiler flags ####
> >>>  
> >>>  AX_APPEND_COMPILE_FLAGS(
> >>> -    [-Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -ffast-math -Wp,-D_FORTIFY_SOURCE=2 -fno-common -fdiagnostics-show-option],
> >>> +    [-Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -ffast-math -fno-common -fdiagnostics-show-option],
> >>
> >> "-Wp," did also disappear here? Not that I know that "-Wp," actually does?
> > 
> > It means "preprocessor option follows". I don't when "-Wp," should be
> > used and when not, but it's not needed when setting the option in
> > CPPFLAGS.
> > 
> 
> Ok. I'm not sure why it seems to be removed from CFLAGS and added to
> CPPFLAGS, but this apparently works for -DFASTPATH, so, acked.

Thanks, pushed both patches.

-- 
Tanu