[pulseaudio-discuss] [PATCH] resampler: Never return zero for max block size

[Tanu Kaskinen]

On Thu, 2013-08-29 at 12:10 +0300, Tanu Kaskinen wrote:
> On Thu, 2013-08-29 at 15:15 +0800, Raymond Yau wrote:
> > With very low input sample rates the memory pool max block size may
> > > not be big enough, in which case we should return the size of one
> > > frame. Returning zero caused crashing.
> > >
> > >
> > http://freedesktop.org/software/pulseaudio/doxygen/sample.html Sample Rates
> > PulseAudio supports any sample rate between 1 Hz and 192000 Hz.
> > 
> > Is pulseaudio used for scientific purpose to support 1Hz ?
> 
> I'm not aware of anyone using 1 Hz sample rate for anything, especially
> for the input rate, which is what this patch deals with. Very low rates
> are can be useful for output for determining the signal level, although
> 1 Hz is probably too low rate even for that (pavucontrol uses 25 Hz for
> the volume meters).
> 
> > you need sampling at 40Hz to record the peak and bottom of 20Hz human
> > audible signal (quality is quite bad at such low sampling rate)
> 
> Yes, that's a valid reason for defining a minimum rate, but I don't
> really see any practical benefit in doing so, so why bother?

No further feedback received, I have now applied this patch.

-- 
Tanu