[pulseaudio-discuss] [PATCH] sink: Increase max sink inputs per sink

[David Henningsson]

On 09/20/2013 05:44 AM, Arun Raghavan wrote:
> We're hitting the 32 sink-input limit quite often with increasing use of
> PA by web browsers, so let's increase this limit.

Does this increase the risk of us being the target of attacks; i e, if a
web browser deliberately starts 255 streams, would we risk getting
killed by using too much rtprio cpu time?

Btw; is there a specific web browser you're looking at?

> ---
>  src/pulsecore/sink.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/pulsecore/sink.h b/src/pulsecore/sink.h
> index 332e2b1..e12faba 100644
> --- a/src/pulsecore/sink.h
> +++ b/src/pulsecore/sink.h
> @@ -48,7 +48,7 @@ typedef struct pa_sink_volume_change pa_sink_volume_change;
>  #include <pulsecore/thread-mq.h>
>  #include <pulsecore/sink-input.h>
>  
> -#define PA_MAX_INPUTS_PER_SINK 32
> +#define PA_MAX_INPUTS_PER_SINK 256
>  
>  /* Returns true if sink is linked: registered and accessible from client side. */
>  static inline bool PA_SINK_IS_LINKED(pa_sink_state_t x) {
> 



-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic