[pulseaudio-discuss] Suggested coding style change for functions

João Paulo Rechi Vita jprvita at gmail.com
Tue Sep 24 08:45:40 PDT 2013


On Mon, Sep 23, 2013 at 7:29 AM, Damir Jelić <poljarinho at gmail.com> wrote:
> On Mon, Sep 23, 2013 at 11:37:33AM +0300, Tanu Kaskinen wrote:
>> On Mon, 2013-09-23 at 10:21 +0200, David Henningsson wrote:
>> > On 09/20/2013 11:23 AM, Peter Meerwald wrote:
>> > > I think both coding styles are sane and I suggest to NOT convert to a new
>> > > style
>> > >
>> > > the 'other projects' is Gnome?
>> >
>> > Gnome, Linux Kernel, FluidSynth (as mentioned previously).
>> >
>> > > there is not the ONE style and it really depends on your personal
>> > > situation which styles you work more often with -- what's good for one
>> > > contributer might not be for another
>> >
>> > Out of curiousity, do you know any bigger open source projects that do
>> > the "no newline" style? I don't think I've ever seen one except for
>> > PulseAudio.
>>
>> Quoting the CODING_STYLE file of systemd:
>>
>>     - Try to use this:
>>
>>           void foo() {
>>           }
>>
>>       instead of this:
>>
>>           void foo()
>>           {
>>           }
>>
>>       But it's OK if you don't.
>>
>
> Add Chromium and LLVM/CLANG to that list.
> But yes, it seems that David is right here and that it is a somewhat
> less common style. It probably would be interesting to see some actual
> numbers here but that would be too much work.

I don't think we should choose the coding style based on what is used
by most projects, but respect was has been used along the project's
history.

-- 
João Paulo Rechi Vita
http://about.me/jprvita


More information about the pulseaudio-discuss mailing list