[pulseaudio-discuss] [PATCH 2/2] gconf: Avoid calling deprecated function if possible

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Thu Apr 24 09:46:23 PDT 2014


On Tue, 2014-04-22 at 10:05 -0300, Felipe Sateler wrote:
> On Tue, Apr 22, 2014 at 4:35 AM, Arun Raghavan <arun at accosted.net> wrote:
> > g_type_init() is need no longer be called explicitly from glib 2.36
> > onwards.
> > ---
> >  src/modules/gconf/gconf-helper.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/src/modules/gconf/gconf-helper.c b/src/modules/gconf/gconf-helper.c
> > index fbd8cfd..3c1180c 100644
> > --- a/src/modules/gconf/gconf-helper.c
> > +++ b/src/modules/gconf/gconf-helper.c
> > @@ -99,7 +99,9 @@ int main(int argc, char *argv[]) {
> >      GConfClient *client;
> >      GSList *modules, *m;
> >
> > +#if !GLIB_CHECK_VERSION(2,36,0)
> >      g_type_init();
> > +#endif
> >
> >      if (!(client = gconf_client_get_default()))
> >          goto fail;
> 
> What happens if pulseaudio is compiled against 2.36+ but is run
> against an older version of glib?

Supposedly the code will not work, because the GLib type system is not
initialized.

> This could happen when using packages compiled on another distro/release.

Installing packages from another distro is not expected to work anyway.

-- 
Tanu



More information about the pulseaudio-discuss mailing list