[pulseaudio-discuss] [PATCH 1/3] resampler: Split the resampler implementations into separate files

[Alexander E. Patrakov]

04.08.2014 18:40, Peter Meerwald wrote:
>   static bool speex_is_fixed_point(void) {

I am of the mixed opinion on the fact that this function is not moved to 
speex.c. The patch subjectively feels incomplete because of that - but 
this function is special due to the fact that it also has to exist (as a 
stub) even without speex.  Maybe it indeed should not be moved, maybe it 
should be moved and a stub has to be created then in resampler.h.

Other than that, the patch looks good.

-- 
Alexander E. Patrakov