[pulseaudio-discuss] [PATCH v2 3/4] bluetooth: Create NULL backend

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Wed Aug 20 05:07:04 PDT 2014


On Tue, 2014-08-19 at 15:54 +0300, Luiz Augusto von Dentz wrote:
> From: João Paulo Rechi Vita <jprvita at openbossa.org>
> 
> ---
>  configure.ac                         | 16 ++++++++++++++++
>  src/Makefile.am                      |  3 ++-
>  src/modules/bluetooth/backend-null.c | 37 ++++++++++++++++++++++++++++++++++++
>  src/modules/bluetooth/bluez5-util.c  |  5 +++++
>  src/modules/bluetooth/bluez5-util.h  |  4 ++++
>  5 files changed, 64 insertions(+), 1 deletion(-)
>  create mode 100644 src/modules/bluetooth/backend-null.c
> 
> diff --git a/configure.ac b/configure.ac
> index dc2298d..33e4214 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1028,6 +1028,21 @@ AS_IF([test "x$HAVE_BLUEZ_4" = "x1" || test "x$HAVE_BLUEZ_5" = "x1"], HAVE_BLUEZ
>  AC_SUBST(HAVE_BLUEZ)
>  AM_CONDITIONAL([HAVE_BLUEZ], [test "x$HAVE_BLUEZ" = x1])
>  
> +## Bluetooth Headset profiles backend ##
> +
> +AC_ARG_WITH(bluetooth_headset_backend,
> +AS_HELP_STRING([--with-bluetooth-headset-backend=<null>],[Backend for Bluetooth headset profiles (null)]))

Repeating what I said last time: Please indent the AS_HELP_STRING line,
since it's inside AC_ARG_WITH.

Other than that, the patches look good.

-- 
Tanu



More information about the pulseaudio-discuss mailing list