[pulseaudio-discuss] [PATCH v3 10/11] udev: Store the seat id in device proplists

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Fri Dec 5 06:22:04 PST 2014


On Fri, 2014-12-05 at 15:00 +0100, David Henningsson wrote:
> 
> On 2014-12-04 19:44, Tanu Kaskinen wrote:
> > When using PulseAudio in system mode, it may be interesting to know
> > which seats the devices are assigned to. This will be used in the
> > tunnel manager to filter out the devices that belong to other users.
> 
> I'd prefer if PA_PROP_UDEV_SEAT was called PA_PROP_DEVICE_SEAT, because 
> the seat a device belongs to could be generically useful to e g volume 
> control clients.

If we make the seat id field non-udev specific, I'm happy with that.
However, in that case I'd prefer to use a separate field in the
appropriate structs instead of using proplists. As I've explained
before, I don't like using proplists for stable core APIs.

> I'd also prefer if it was not filled in in case there was no such udev 
> property, to rule out any possibility it gets filled in with the wrong 
> value.

If a udev device has the "seat" tag, but the "ID_SEAT" property isn't
set, then the implied seat id is "seat0". This is documented behaviour
of udev.

-- 
Tanu



More information about the pulseaudio-discuss mailing list