[pulseaudio-discuss] ABI breakage in introspect (85e7fbc196f4424f68e530c2e3a01d9b941f293e)

[Colin Guthrie]

'Twas brillig, and Colin Guthrie at 09/01/14 10:16 did gyre and gimble:
> 'Twas brillig, and Colin Guthrie at 09/01/14 10:07 did gyre and gimble:
>>> @@ -929,6 +956,7 @@ static void context_get_card_info_callback(pa_pdispatch *pd, uint32_t command, u
>>>                  for (j = 0; j < i.n_profiles; j++)
>>>                      if (pa_streq(i.profiles[j].name, ap)) {
>>>                          i.active_profile = &i.profiles[j];
>>> +                        i.active_profile2 = i.profiles2[j];
>>>                          break;
>>>                      }
> 
> This hunk at least looks wrong but I cannot see it causing the problem
> seeing as active_profile2 does not appear to be used yet...

Ahh no, I stand corrected, profiles2 is ** so no need for &.

The only material change I can see is the dropping of some explicit
nullification of the extra terminating element.

>From my reading of the code this shouldn't be needed as pa_xnew0 should
make it unnecessary and initialise the memory to 0 anyway. That said,
I'll send the patch as a reply to this mail and I've asked the people
who had the problem to test a build with this included. I'm quite
sceptical that it will may any difference, but after reviewing the
changes in introspection from v4.0..master, it's the only change I see
missing :s

If someone else's eyes are better than mine please do speak up! :)

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/