[pulseaudio-discuss] [PATCH] introspect: Fix a minor ABI regression introduced in 85e7fbc196

[Colin Guthrie]

'Twas brillig, and Arun Raghavan at 09/01/14 12:17 did gyre and gimble:
> On Thu, 2014-01-09 at 11:44 +0000, Colin Guthrie wrote:
>> It seems that when converting to profiles2, the extra NULL terminated
>> profile object used in profiles was dropped. This caused regressions
>> in e.g. pavucontrol and kcm_phonon which relied on the previous
>> (documented) behaviour.
>>
>> The above said, this *shouldn't* be needed as far as I can see.
>> The use of pa_xnew0 should initialise the memory to zero and thus
>> these variables should already be NULL. Issues have been reported
>> so the problem does seem to need fixing in some capacity:
>>
>> See https://bugs.mageia.org/show_bug.cgi?id=12155
>> ---
> 
> As you say, this shouldn't be necessary. Please hold off on pushing this
> until we understand if it does fix the problem and why.

Yup, my previous mail referred to me pushing it to people who can test
it, so I'll let you know if it does actually make a difference (and
perhaps try another build after with it reverted again "just in case" a
simple rebuild is actually all that was needed).

It's definitely confusing but I think you can see from the backtracks on
those bugs that there is definitely something funny with the card
introspection.

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/