[pulseaudio-discuss] [PATCH 30/30] core-format, sink-input, source-output: Add some more logging

[Tanu Kaskinen]

---
 src/pulsecore/core-format.c   | 2 ++
 src/pulsecore/sink-input.c    | 4 +++-
 src/pulsecore/source-output.c | 4 +++-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/pulsecore/core-format.c b/src/pulsecore/core-format.c
index 6e534f4..b9589ed 100644
--- a/src/pulsecore/core-format.c
+++ b/src/pulsecore/core-format.c
@@ -47,5 +47,7 @@ int pa_format_info_negotiate(pa_idxset *formats_a, pa_idxset *formats_b, const p
         }
     }
 
+    pa_log_info("No compatible formats found.");
+
     return -PA_ERR_NOTSUPPORTED;
 }
diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c
index ad3dc6e..3f8af98 100644
--- a/src/pulsecore/sink-input.c
+++ b/src/pulsecore/sink-input.c
@@ -871,8 +871,10 @@ int pa_sink_input_set_initial_sink(pa_sink_input *i, pa_sink *sink) {
     r = pa_format_info_negotiate(i->req_formats, sink_formats, &format);
     pa_idxset_free(sink_formats, (pa_free_cb_t) pa_format_info_free);
 
-    if (r < 0)
+    if (r < 0) {
+        pa_log_info("Format negotiation between sink input %u and sink %s failed.", i->index, sink->name);
         return r;
+    }
 
     if (i->format)
         pa_format_info_free(i->format);
diff --git a/src/pulsecore/source-output.c b/src/pulsecore/source-output.c
index f243e8d..177c180 100644
--- a/src/pulsecore/source-output.c
+++ b/src/pulsecore/source-output.c
@@ -743,8 +743,10 @@ int pa_source_output_set_initial_source(pa_source_output *o, pa_source *source)
     r = pa_format_info_negotiate(o->req_formats, source_formats, &format);
     pa_idxset_free(source_formats, (pa_free_cb_t) pa_format_info_free);
 
-    if (r < 0)
+    if (r < 0) {
+        pa_log_info("Format negotiation failed between source output %u and source %s.", o->index, source->name);
         return r;
+    }
 
     if (o->format)
         pa_format_info_free(o->format);
-- 
1.8.3.1