[pulseaudio-discuss] [PATCH] bluetooth: Don't abort on SBC decoding error
James Bunton
jamesbunton at delx.net.au
Sat Jan 18 01:14:39 PST 2014
Hi Tanu,
Thanks for the quick review! :)
My mobile phone (Nokia E7 running Symbian Belle Refresh) is connecting
to pulseaudio/bluez running on my Arch Linux on my Raspberry Pi. Without
this patch every few minutes pulseaudio will disconnect the stream and
log "SBC decoding error (-3)". As you can imagine this is quite
annoying! :)
I see what you mean about the timing code being wrong. What does
pulseaudio use this for? Should I expect to hear some audio glitches
with the current incorrect code, or is it just for display in a GUI?
I've modified it to use the number of bytes that sbc_decode reports it
wrote to the output buffer. Both versions seem to work equally well for
me.
You can see them here:
Repo URL: http://delx.net.au/git/pulseaudio
Patch1:
http://delx.net.au/git/pulseaudio/commitdiff/f66bec680d5a78778ef44910807020724ba4ebae
Patch2:
http://delx.net.au/git/pulseaudio/commitdiff/ba134901487a30633beafe335a5670a6586a65d4
I can submit these as patch files with git-send-email if that's
preferable for review.
Thanks again :)
--
James
More information about the pulseaudio-discuss
mailing list