[pulseaudio-discuss] [RFCv0 19/21] bluetooth: Rename variable to improve code readability

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Sun Jun 1 03:52:07 PDT 2014


On Tue, 2014-02-04 at 19:04 -0300, jprvita at gmail.com wrote:
> From: João Paulo Rechi Vita <jprvita at openbossa.org>
> 
> The label 'u' is used throughout the code to name pointers to the struct
> userdata.
> ---
>  src/modules/bluetooth/module-bluez5-device.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c
> index 0b97975..f1991a0 100644
> --- a/src/modules/bluetooth/module-bluez5-device.c
> +++ b/src/modules/bluetooth/module-bluez5-device.c
> @@ -1988,15 +1988,15 @@ static pa_hook_result_t transport_state_changed_cb(pa_bluetooth_discovery *y, pa
>  
>  /* Run from main thread context */
>  static int device_process_msg(pa_msgobject *obj, int code, void *data, int64_t offset, pa_memchunk *chunk) {
> -    struct bluetooth_msg *u = BLUETOOTH_MSG(obj);
> +    struct bluetooth_msg *m = BLUETOOTH_MSG(obj);
>  
>      switch (code) {
>          case BLUETOOTH_MESSAGE_IO_THREAD_FAILED:
> -            if (u->card->module->unload_requested)
> +            if (m->card->module->unload_requested)
>                  break;
>  
>              pa_log_debug("Switching the profile to off due to IO thread failure.");
> -            pa_assert_se(pa_card_set_profile(u->card, pa_hashmap_get(u->card->profiles, "off"), false) >= 0);
> +            pa_assert_se(pa_card_set_profile(m->card, pa_hashmap_get(m->card->profiles, "off"), false) >= 0);
>              break;
>      }
>  

I applied this one.

-- 
Tanu



More information about the pulseaudio-discuss mailing list