[pulseaudio-discuss] [RFCv0 12/21] bluetooth: Implement transport acquire for hf_audio_agent transports
tanu.kaskinen at linux.intel.com
Sun Jun 1 05:08:19 PDT 2014
On Fri, 2014-05-30 at 13:07 +0300, Tanu Kaskinen wrote:
> On Tue, 2014-02-04 at 19:03 -0300, jprvita at gmail.com wrote:
> > + t->codec = hfac->codec;
> > +
> > + /* Do the socket deferred setup */
> > + if (recv(hfac->fd, NULL, 0, 0) < 0)
> hfac->fd is always -1. Patches in wrong order? Well, you also pass NULL
> as the buffer, so I suppose it's intentional that this will always fail.
> A TODO comment would be nice if you implement broken stuff on purpose.
It seems that the buffer was not changed to non-NULL in any of the
subsequent patches. Please add more explanation to the comment about
what this "deferred setup" means and is trying to achieve. Reading zero
bytes seems silly to someone who doesn't know what the "deferred setup"
More information about the pulseaudio-discuss