[pulseaudio-discuss] [PATCH 0/4] Current Ubuntu phone patch set

David Henningsson david.henningsson at canonical.com
Mon Jun 9 22:47:53 PDT 2014



On 2014-06-06 14:20, Tanu Kaskinen wrote:
> On Wed, 2013-09-18 at 16:01 +0200, David Henningsson wrote:
>> Ok, so the Ubuntu Phone's audio stack is pretty much set for Ubuntu 13.10, so
>> perhaps it's time to show what I've been up to.
>>
>> The first patch is jack detection and is pretty much independent. It adds support
>> for Android switch jack detection.
>>
>> Then follows two small patches which are both prerequisites for the last one,
>> which adds support for talking to the Android audio HAL for setting up and
>> tearing down voice calls.
>>
>> Any comments, questions, etc?
>>
>> David Henningsson (4):
>>    alsa: Add extcon (Android switch) jack detection
>>    alsa-ucm: Don't probe UCM
>>    card: Add hook before profile changes
>>    alsa: Add module to talk to the Android audio hal to set up voice
>>      calls
>>
>>   configure.ac                                |   17 +
>>   src/Makefile.am                             |   13 +
>>   src/daemon/default.pa.in                    |    4 +
>>   src/modules/alsa/alsa-extcon.c              |  272 ++++++++++++++
>>   src/modules/alsa/alsa-extcon.h              |   33 ++
>>   src/modules/alsa/alsa-ucm.c                 |    8 +-
>>   src/modules/alsa/alsa-ucm.h                 |    1 +
>>   src/modules/alsa/module-alsa-card.c         |    5 +
>>   src/modules/alsa/module-android-audio-hal.c |  508 +++++++++++++++++++++++++++
>>   src/pulsecore/card.c                        |    2 +
>>   src/pulsecore/core.h                        |    1 +
>>   11 files changed, 861 insertions(+), 3 deletions(-)
>>   create mode 100644 src/modules/alsa/alsa-extcon.c
>>   create mode 100644 src/modules/alsa/alsa-extcon.h
>>   create mode 100644 src/modules/alsa/module-android-audio-hal.c
>
> There was some talk about replacing this with the Android module that
> Jolla uses, but no decision, IIRC. What are your plans regarding that?
> I'm asking, because if you go with Jolla's module, then I won't review
> these patches.

Yeah, let's wait for what Jolla has to say about their upstreaming plans 
for their module(s).

That said, AFAIK the Jolla module does not have the extcon/switch module 
for jack detection, so maybe that part is still valid to upstream...?

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


More information about the pulseaudio-discuss mailing list