[pulseaudio-discuss] [PATCH 2/2] rtsp_client: set disconnect state call cb when on_connection fails

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Fri Mar 14 07:05:34 PDT 2014

On Thu, 2014-03-13 at 12:01 +0100, Alexander Couzens wrote:
> On Fri, 07 Feb 2014 17:43:54 +0200
> Tanu Kaskinen <tanu.kaskinen at linux.intel.com> wrote:
> > As far as I can see, it doesn't make sense to pass c->response_headers
> > here, because the connection was never established, so there can't be
> > any response headers.
> > 
> right. these pointers are null. I just want to be coherent with other callbacks
> in this file.

Ok. In my opinion it's much clearer if you pass NULL instead of a
variable if you know it's NULL anyway. Doing otherwise suggests to me
that the variable can be non-NULL, which then causes confusion.


More information about the pulseaudio-discuss mailing list