[pulseaudio-discuss] [PATCH] pactl: Fix crash with older servers

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Wed Mar 19 00:12:02 PDT 2014


On Tue, 2014-03-18 at 14:24 +0100, Peter Meerwald wrote:
> Hello Tanu,
> 
> > Servers older than 0.9.15 don't know anything about cards, and card
> > operations will return a NULL pa_operation object when connected to
> > that old server. We must check the pa_operation pointer before passing
> > it to pa_operation_unref(), otherwise a NULL operation will result in
> > a crash.
> 
> I found the purpose of the actions variable quite hard to understand, a 
> comment would be good explaining the logic

Ok, I'll do that.

-- 
Tanu



More information about the pulseaudio-discuss mailing list