[pulseaudio-discuss] [PATCH v2] sink/source: Initialize port before fixate hook (fixes volume/mute not saved)

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Tue Mar 25 01:15:57 PDT 2014


On Tue, 2014-03-25 at 08:05 +0100, David Henningsson wrote:
> In case a port has not yet been saved, which is e g often the case
> if a sink/source has only one port, reading volume/mute will be done
> without port, whereas writing volume/mute will be done with port.
> 
> Work around this by setting a default port before the fixate hook,
> so module-device-restore can read volume/mute for the correct port.
> 
> BugLink: https://bugs.launchpad.net/bugs/1289515
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
> ---
>  src/pulsecore/device-port.c |   27 +++++++++++++++++++++++++++
>  src/pulsecore/device-port.h |    2 ++
>  src/pulsecore/sink.c        |   27 ++++++++++-----------------
>  src/pulsecore/source.c      |   28 ++++++++++------------------
>  4 files changed, 49 insertions(+), 35 deletions(-)

Looks good to me.

-- 
Tanu



More information about the pulseaudio-discuss mailing list