[pulseaudio-discuss] [PATCH v2 0/2] Helper functions for pa_direction_t

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Wed Mar 26 02:52:32 PDT 2014

>From the original cover letter:

I found pa_direction_valid() and pa_direction_to_string() useful in
the Tizen volume API work, and I thought they might make sense in
upstream too.

I found one place in the current code base where pa_direction_valid()
makes sense, but I didn't find any use for pa_direction_to_string() at
this time. Should I push both functions to upstream, or just
pa_direction_valid(), or neither? If I get no answers, I will push

Changes in v2:
    - Include direction.h from pulseaudio.h.
    - Add direction.h to doxygen inputs.
    - Fix doxygen comment formatting.

Tanu Kaskinen (2):
  direction: Add a couple of direction helper functions
  introspect: Use pa_direction_valid() to validate port direction

 doxygen/doxygen.conf.in |  1 +
 src/Makefile.am         |  2 ++
 src/map-file            |  2 ++
 src/pulse/direction.c   | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 src/pulse/direction.h   | 37 +++++++++++++++++++++++++++++++++++++
 src/pulse/introspect.c  |  6 +++---
 src/pulse/pulseaudio.h  |  5 +++--
 7 files changed, 94 insertions(+), 5 deletions(-)
 create mode 100644 src/pulse/direction.c
 create mode 100644 src/pulse/direction.h


More information about the pulseaudio-discuss mailing list