[pulseaudio-discuss] Patch review status wiki page updated

Alexander E. Patrakov patrakov at gmail.com
Fri May 9 10:10:09 PDT 2014


09.05.2014 18:42, Tanu Kaskinen wrote:
> Patch review status updated:
> http://www.freedesktop.org/wiki/Software/PulseAudio/PatchStatus/

> pulseaudio won't run when home directory is mounted with CIFS
>
>     From: Maarten Jacobs
>     Submission date: 2013-11-15
>     In bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71649

IMHO this is obsolete due to commit f2f5dffb1dcc4fd8481e58a686d088e4286441b0

Also the following entries are related to the same issue:

> resampler: Support speex resampler compiled with FIXED_POINT
>
>     From: Peter Meerwald
>     Submission date: 2014-04-03
>     On the mailing list: http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/20004

and

> When Speex is compiled with FIXED_POINT defined, it scales float input to +/-32768 instead of +/-1. But Pulseaudio invokes speex float method with input in range of +/-1. So in order to make floating point resamplers work with Speex compiled with FIXED_POINT, we need to rescale the input to Speex.
>
>     From: Fahad Arslan
>     Submission date: 2013-12-23
>     Review date: 2013-12-25
>     On the mailing list: http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/19296

...so the second one should be removed from the list, because Peter 
Meerwald added important runtime probing. The second patch seems to be 
broken for "normal" speex. I intend to review Peter's patch tomorrow.

-- 
Alexander E. Patrakov


More information about the pulseaudio-discuss mailing list