[pulseaudio-discuss] [PATCH v2] resampler: Support speex resampler compiled with FIXED_POINT

Alexander E. Patrakov patrakov at gmail.com
Sat May 10 09:53:01 PDT 2014


10.05.2014 22:45, Peter Meerwald wrote:
>
>> When Speex is compiled with FIXED_POINT defined, it scales float input
>> to ±32768 instead of ±1. In order to make floating point resampler
>> work with speex compiled with FIXED_POINT, we need to rescale the input
>> to speex. This rescaling does not hurt normal speex, so we do it
>> unconditionally.
>
> floating point multiplication is quite costly on some platforms, I'd
> rather not force everyone to scale every sample twice for no good reason

Well, on such platforms (*cough* ARM *cough*) I'd call it a bug to use 
speex-float-* resamplers by default, or even to provide them at all. If 
we fix that, then the extra multiplication in an already-very-slow path 
would no longer be relevant.

-- 
Alexander E. Patrakov


More information about the pulseaudio-discuss mailing list