[pulseaudio-discuss] [PATCH 06/11] memblock, pstream: Allow send/receive of remote writable memblocks

David Henningsson david.henningsson at canonical.com
Fri May 30 03:57:20 PDT 2014



On 2014-05-06 16:21, Peter Meerwald wrote:
>> diff --git a/src/pulsecore/memblock.c b/src/pulsecore/memblock.c
>> >index 8da0fcd..5ef2aa9 100644
>> >--- a/src/pulsecore/memblock.c
>> >+++ b/src/pulsecore/memblock.c
>> >@@ -97,6 +97,7 @@ struct pa_memimport_segment {
>> >      pa_shm memory;
>> >      pa_memtrap *trap;
>> >      unsigned n_blocks;
>> >+    bool writable;
> is this really needed?

It's just a sanity check to make sure the other side doesn't try to do 
something weird, like being inconsistent on whether a specific shm 
segment is writable.

Unless there is a bug or "malicious" remote side this should never happen.

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


More information about the pulseaudio-discuss mailing list