[pulseaudio-discuss] [PATCH 4/8] socket-server: Add support for systemd socket activation.

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Mon Nov 3 01:01:39 PST 2014


On Mon, 2014-11-03 at 10:59 +0200, Tanu Kaskinen wrote:
> One more comment about this patch...
> 
> On Sat, 2014-10-18 at 20:43 +0200, Colin Guthrie wrote:
> > @@ -374,7 +378,7 @@ int main(int argc, char *argv[]) {
> >      int r = 0, retval = 1, d = 0;
> >      bool valid_pid_file = false;
> >      bool ltdl_init = false;
> > -    int passed_fd = -1;
> > +    int n, *passed_fds = NULL;
> 
> n is only used if HAVE_SYSTEMD_DAEMON is defined. If it's not defined,
> there will be a compiler warning about unused variable.

Sorry, I quoted a wrong part of the code... The problematic n is in
pa_socket_server_new_unix().

-- 
Tanu



More information about the pulseaudio-discuss mailing list