[pulseaudio-discuss] [PATCH 4/8] socket-server: Add support for systemd socket activation.

[Colin Guthrie]

Colin Guthrie wrote on 03/11/14 09:12:
> Tanu Kaskinen wrote on 03/11/14 09:01:
>> On Mon, 2014-11-03 at 10:59 +0200, Tanu Kaskinen wrote:
>>> One more comment about this patch...
>>>
>>> On Sat, 2014-10-18 at 20:43 +0200, Colin Guthrie wrote:
>>>> @@ -374,7 +378,7 @@ int main(int argc, char *argv[]) {
>>>>      int r = 0, retval = 1, d = 0;
>>>>      bool valid_pid_file = false;
>>>>      bool ltdl_init = false;
>>>> -    int passed_fd = -1;
>>>> +    int n, *passed_fds = NULL;
>>>
>>> n is only used if HAVE_SYSTEMD_DAEMON is defined. If it's not defined,
>>> there will be a compiler warning about unused variable.
>>
>> Sorry, I quoted a wrong part of the code... The problematic n is in
>> pa_socket_server_new_unix().
> 
> Ahh good timing... was just going to send a v2 shortly... will get this
> into it too :)

Oh and there were actually two problematic n's... there was another in
the stale check in socket-util.c too!

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/