[pulseaudio-discuss] [PATCH 4/8] socket-server: Add support for systemd socket activation.

[Colin Guthrie]

Tanu Kaskinen wrote on 03/11/14 11:04:
> On Mon, 2014-11-03 at 09:42 +0000, Colin Guthrie wrote:
>>  pa_socket_server* pa_socket_server_new_unix(pa_mainloop_api *m, const char *filename) {
>>      int fd = -1;
>> +    bool activated = false;
>>      struct sockaddr_un sa;
>>      pa_socket_server *s;
>>  
>>      pa_assert(m);
>>      pa_assert(filename);
>>  
>> -    if ((fd = pa_socket_cloexec(PF_UNIX, SOCK_STREAM, 0)) < 0) {
>> -        pa_log("socket(): %s", pa_cstrerror(errno));
>> -        goto fail;
>> +#ifdef HAVE_SYSTEMD_DAEMON
>> +    int n = sd_listen_fds(0);
> 
> Now there's another warning (also in pa_unix_socket_remove_stale()):
> 
> warning: ISO C90 forbids mixed declarations and code
> [-Wdeclaration-after-statement]


<facepalm>




-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/