[pulseaudio-discuss] Should corking be acknowledged by pa_sink_suspend()?

[Arun Raghavan]

On 10 November 2014 19:59, Ville Sundell <ville.sundell at nomovok.com> wrote:
> Hello again!
> I've traced the invocation of pa_sink_suspend(), and the erroneous uncorking
> seems to lead to module-suspend-on-idle.so. Going to dig more into that.

Right, so that uncorking is likely the culprit.

> However, it seems that PA_SINK_SUSPENDED and PA_SINK_INPUT_CORKED are
> accidentally sharing the same enum placement, could it be that situation

PA_SINK_* and PA_SINK_INPUT_* enums are unrelated - their values may
overlap, and it has no significance.

> where suspending cause (s->suspend_cause) is 0, and sink is already
> suspended, should be handled anyway? (just changing PA_SINK_INPUT_CORKED to
> PA_SINK_SUSPENDED?)

If s->suspend_cause is 0, that means all the causes to suspend the
sink have gone away and that we should unsuspend the sink.

Regards,
Arun