[pulseaudio-discuss] systemd socket activation support

[Colin Guthrie]

Jaska Uimonen wrote on 24/10/14 06:46:
> And thanks for the patches, I really need these for Tizen IVI.
> 
> In my initial testing they seem to work fine, however couple
> of observations:
> 
> in socket-server.c the systemd headers are behind the systemd
> enabler flags (like they should be), but that is behind some
> HAVE_LIBWRAP thing. I had to move the include outside to get
> the patches compiled.

Oops. Carelessness on my part. Moved in my tree.

> in main.c you are defining int n, but there's later ssize_t n
> which gives you shadowed declaration warning, but thats mainly
> cosmetics.

Also fixed in my tree (renamed to n_fds just to avoid conflict).

> Colin sorry to drop the comments in pieces...
> so one more thing:
>
> in socket-server.c:
>
> in the creation there's always:
> "s->filename = strdup"
>
> but for cleanup you have added:
> "!s->activated" flag...
>
> is the "activated" flag needed for some reason in the
> cleanup?

Ahh yes, fixed that in my tree too (only avoid the unlink, not the free).

Thanks for the review!


Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/