[pulseaudio-discuss] [PATCH 7/8] launch: Disable autospawn by default when systemd daemon support is enabled.

Colin Guthrie gmane at colin.guthr.ie
Fri Oct 24 03:14:53 PDT 2014


Tanu Kaskinen wrote on 24/10/14 10:42:
> On Sat, 2014-10-18 at 20:43 +0200, Colin Guthrie wrote:
>> This method is prefered over pulseaudio's built in systems so we should
>> try our best to ensure that it cannot be spawned outside of the mechanisms
>> desired.
> 
> Would it make sense to disable all autospawn related code when
> HAVE_SYSTEMD_DAEMON is defined?

Possibly yeah (I certainly wouldn't disapprove). I think that could be
done as a follow up patch rather than a pre-requisite for including this
current series. Or would you rather I look into this more just now?

>> We also disable the manual override of enabling the socket and force it to
>> be enabled at install time.
> 
> "Disable the manual override" doesn't sound like a good idea... Does
> this mean that "systemctl --user disable pulseaudio.socket" doesn't
> work?

Yes, but it also has the advantage that every single user on the system
doesn't have to run "systemctl --user enable pulseaudio.socket" before
their sound will work. If distros ship this, they will definitely ship
this symlink or something similar to it, so I think doing this by
default makes sense for us too.

In this scenario (when the distributor has decided the default action
but the user disagrees), "systemctl --user mask pulseaudio.socket" is
the recommended approach (as I detailed in the wiki page). See also
http://0pointer.de/blog/projects/three-levels-of-off for background on
masking.

That said, I can see that in an IVI setup, you don't really need PA
sockets for users that may exist but would never have any reason to run
any audio system. In such a case, I'd expect them NOT to have a
system-wide default but to configure each user appropriately as per
their needs (effectively just moving/copying the symlink in
/usr/lib/systemd/user/socket.target.wants/ to
~/.config/systemd/user/socket.target.wants/ of the appropriate user(s)).
I would argue that this is something the system-integrator would do and
could thus happily [re]move this symlink easily enough, but we should
still ship it by default.

If you agree with the logic would you like me to improve the commit
message a bit to give more detail?

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/


More information about the pulseaudio-discuss mailing list