[pulseaudio-discuss] [PATCH] alsa-mixer: Improve workaround for Valgrind's false warnings

[David Henningsson]

On 2014-09-07 12:24, Tanu Kaskinen wrote:
> On Tue, 2014-09-02 at 16:11 +0200, David Henningsson wrote:
>> Valgrind is not correctly handling ALSA TLV syscalls, which leads
>> to false warnings, looking like this:
>>   "Conditional jump or move depends on uninitialised value(s)"
>>
>> Unfortunately, alsa-lib itself also uses these values which valgrind
>> falsely believe are uninitialized, so not all warnings are removed,
>> but this is what we can do from PA until the valgrind bug is fixed.
>>
>> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
>> ---
>>   src/modules/alsa/alsa-mixer.c | 61 ++++++++++++++++++++++++++++++++++++-------
>>   1 file changed, 52 insertions(+), 9 deletions(-)
>
> Looks good to me.

Thanks, pushed.

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic