[pulseaudio-discuss] [PATCH v2 11/14] bluetooth: Implement org.ofono.HandsfreeAudioAgent.Release()

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Thu Sep 11 04:05:30 PDT 2014


On Wed, 2014-09-10 at 11:48 +0200, Luiz Augusto von Dentz wrote:
> From: João Paulo Rechi Vita <jprvita at openbossa.org>
> 
> ---
>  src/modules/bluetooth/backend-ofono.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c
> index c23f495..c17aed7 100644
> --- a/src/modules/bluetooth/backend-ofono.c
> +++ b/src/modules/bluetooth/backend-ofono.c
> @@ -491,7 +491,15 @@ static DBusMessage *hf_audio_agent_release(DBusConnection *c, DBusMessage *m, vo
>          return r;
>      }
>  
> -    r = dbus_message_new_error(m, "org.ofono.Error.NotImplemented", "Operation is not implemented");
> +    pa_log_debug("HF audio agent has been unregistered by oFono (%s)", backend->ofono_bus_id);
> +
> +    pa_hashmap_remove_all(backend->cards);
> +
> +    pa_xfree(backend->ofono_bus_id);
> +    backend->ofono_bus_id = NULL;
> +
> +    pa_assert_se(r = dbus_message_new_method_return(m));
> +
>      return r;
>  }
>  

I have now pushed patches 1-11. Patch 12 had some small issue and I
didn't look at the last two patches yet.

Btw, I'd like a cover letter for patch series. If there was a cover
letter, I would have sent this mail as a reply to the cover letter.

-- 
Tanu



More information about the pulseaudio-discuss mailing list