[pulseaudio-discuss] [PATCH 03/13] tests: Drop address of the FSF in copyright header

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Mon Sep 15 01:22:57 PDT 2014


On Mon, 2014-09-08 at 15:53 +0200, David Henningsson wrote:
> I'm not sure why we should drop it, nor keep it. Is there a good reason?

Quoting Linux checkpatch.pl:

    Do not include the paragraph about writing to the Free Software
    Foundation's mailing address from the sample GPL notice. The FSF
    has changed addresses in the past, and may do so again. Linux
    already includes a copy of the GPL.

I don't see the logic in removing the address only from these four
files, when the address appears in pretty much every file.

-- Tanu

> On 2014-04-24 18:50, Peter Meerwald wrote:
> > From: Peter Meerwald <p.meerwald at bct-electronic.com>
> >
> > Signed-off-by: Peter Meerwald <pmeerw at pmeerw@>
> > ---
> >   src/tests/cpu-mix-test.c    |    5 -----
> >   src/tests/cpu-remap-test.c  |    5 -----
> >   src/tests/cpu-sconv-test.c  |    5 -----
> >   src/tests/cpu-volume-test.c |    5 -----
> >   4 files changed, 20 deletions(-)
> >
> > diff --git a/src/tests/cpu-mix-test.c b/src/tests/cpu-mix-test.c
> > index 934c33f..a1a16d4 100644
> > --- a/src/tests/cpu-mix-test.c
> > +++ b/src/tests/cpu-mix-test.c
> > @@ -10,11 +10,6 @@
> >     WITHOUT ANY WARRANTY; without even the implied warranty of
> >     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> >     General Public License for more details.
> > -
> > -  You should have received a copy of the GNU Lesser General Public License
> > -  along with PulseAudio; if not, write to the Free Software
> > -  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> > -  USA.
> >   ***/
> >
> >   #ifdef HAVE_CONFIG_H
> > diff --git a/src/tests/cpu-remap-test.c b/src/tests/cpu-remap-test.c
> > index 4b8ddd7..039beff 100644
> > --- a/src/tests/cpu-remap-test.c
> > +++ b/src/tests/cpu-remap-test.c
> > @@ -10,11 +10,6 @@
> >     WITHOUT ANY WARRANTY; without even the implied warranty of
> >     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> >     General Public License for more details.
> > -
> > -  You should have received a copy of the GNU Lesser General Public License
> > -  along with PulseAudio; if not, write to the Free Software
> > -  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> > -  USA.
> >   ***/
> >
> >   #ifdef HAVE_CONFIG_H
> > diff --git a/src/tests/cpu-sconv-test.c b/src/tests/cpu-sconv-test.c
> > index f89f593..b75e0af 100644
> > --- a/src/tests/cpu-sconv-test.c
> > +++ b/src/tests/cpu-sconv-test.c
> > @@ -10,11 +10,6 @@
> >     WITHOUT ANY WARRANTY; without even the implied warranty of
> >     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> >     General Public License for more details.
> > -
> > -  You should have received a copy of the GNU Lesser General Public License
> > -  along with PulseAudio; if not, write to the Free Software
> > -  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> > -  USA.
> >   ***/
> >
> >   #ifdef HAVE_CONFIG_H
> > diff --git a/src/tests/cpu-volume-test.c b/src/tests/cpu-volume-test.c
> > index 659136e..92a6dd2 100644
> > --- a/src/tests/cpu-volume-test.c
> > +++ b/src/tests/cpu-volume-test.c
> > @@ -10,11 +10,6 @@
> >     WITHOUT ANY WARRANTY; without even the implied warranty of
> >     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> >     General Public License for more details.
> > -
> > -  You should have received a copy of the GNU Lesser General Public License
> > -  along with PulseAudio; if not, write to the Free Software
> > -  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> > -  USA.
> >   ***/
> >
> >   #ifdef HAVE_CONFIG_H
> >
> 




More information about the pulseaudio-discuss mailing list