[pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

[Alexander E. Patrakov]

18.09.2014 19:27, Colin Leroy wrote:
> On Thu, 18 Sep 2014 19:17:53 +0600, "Alexander E. Patrakov"
> <patrakov at gmail.com> wrote:
>
>> I had a look at the diff between the master and the end result. Too
>> much whitespace changes and other non-functional changes (e.g. I
>> don't understand why the definition of struct userdata has to be
>> moved up in odule-raop-discover.c). I have not looked at the
>> individual commits.
>
> Most of the whitespace changes are actually extra whitespace removal. Do
> you think I should revert those? I agree that they make the diff
> longer, but that seems like wasting the time of the people who did
> these fixes...

Well, if you prefer to have them, then OK, let's have them (and only 
them) at the beginning and only functional changes at the end. If some 
patch adds badly-formatted code only to be fixed up later, please squash 
the formatting fixup into the original patch.

>
>> Also, you have some "unimplemented" stuff like AAC encoding. Could
>> you please remove it? We can always use ALAC, and already have a
>> presumably-working standalone "encoder" (that just slaps a header
>> with an is-not-compressed bit) implementation in write_ALAC_data().
>
> Sure.

Also forgot to say: some patches in the series look like fixups for 
others. E.g. "raop: Add a MD5 hashing fuction" and "raop: Correct the 
MD5 hashing helper function". I think it is a good idea to squash such 
fixups.

-- 
Alexander E. Patrakov