[pulseaudio-discuss] [PATCH v2] Add a Valgrind suppression file

[Alexander E. Patrakov]

21.09.2014 14:05, Tanu Kaskinen wrote:
> ---
>
> New in v2: added the file to EXTRA_DIST, added a comment on the top
> of the file, and also added two new suppression rules that are
> triggered only after a fresh reboot (or after restarting the
> alsa-state service).

The patch looks good now.

>
>
>
>   Makefile.am     |  1 +
>   pulseaudio.supp | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 51 insertions(+)
>   create mode 100644 pulseaudio.supp
>
> diff --git a/Makefile.am b/Makefile.am
> index ddbf64a..07dc73f 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -21,6 +21,7 @@ EXTRA_DIST = \
>   	bootstrap.sh \
>   	git-version-gen \
>   	LICENSE \
> +	pulseaudio.supp \
>   	GPL \
>   	LGPL \
>   	doxygen/Makefile.am \
> diff --git a/pulseaudio.supp b/pulseaudio.supp
> new file mode 100644
> index 0000000..83f9ad1
> --- /dev/null
> +++ b/pulseaudio.supp
> @@ -0,0 +1,50 @@
> +# This file contains error suppression rules for Valgrind. These rules suppress
> +# errors in alsa-lib that are caused by Valgrind not handling the
> +# SNDRV_CTL_IOCTL_TLV_READ ioctl. More information about the Valgrind bug:
> +# http://thread.gmane.org/gmane.comp.debugging.valgrind/11888
> +#
> +# To use this file, pass the command line option --suppressions=<filename> to
> +# Valgrind.
> +#
> +# If you find new false positives, and want to add new suppressions, the
> +# --gen-suppression=all option can be very useful. It prints automatically
> +# generated suppression rules that can be copy-pasted here.
> +
> +{
> +        alsa-lib/snd_tlv_get_dB_range
> +        Memcheck:Cond
> +        fun:snd_tlv_get_dB_range
> +}
> +
> +{
> +        alsa-lib/snd_tlv_convert_to_dB
> +        Memcheck:Cond
> +        fun:snd_tlv_convert_to_dB
> +}
> +
> +{
> +        alsa-lib/snd_tlv_convert_from_dB
> +        Memcheck:Cond
> +        fun:snd_tlv_convert_from_dB
> +}
> +
> +{
> +        alsa-lib/set_volume_ops
> +        Memcheck:Cond
> +        fun:set_volume_ops
> +}
> +
> +{
> +        alsa-lib/snd_ctl_hw_elem_write
> +        Memcheck:Param
> +        ioctl(generic)
> +        fun:ioctl
> +        fun:snd_ctl_hw_elem_write
> +}
> +
> +{
> +        alsa-lib/selem_read
> +        Memcheck:Cond
> +        fun:bcmp
> +        fun:selem_read
> +}
>

-- 
Alexander E. Patrakov