[pulseaudio-discuss] [PATCH 0/3] Multichannel fixes

[Takashi Sakamoto]

Hi David,

On May 31 2015 21:38, David Henningsson wrote:
> About the first patch:
> 
> I tested and refined a patch previously submitted by Takashi
> Sakamoto. It seems like nothing has happened on the udev side so I
> suggest we take this one for now. In case udev should improve and get a
> model database for the Firewire bus, then we could consider
> reverting this.

Thanks for the revised version of my patch (how stupid mistake to use
'IO_' instead of 'ID_' in my comment!) and I'm sorry to have little time
for this issue...

Well, I want to test this patchset with my devices in this weekend. In
my understanding, these patches are for devices with different PCM
channels for playback/capture. In this case, your patch allows
pulseaudio clients to send/receive the first 4 channels
(left,right,rear-left,rear-right) to/from the PCM substreams instead of
using whole channels.

Is my understanding is correct?

> With all three patches, my FireWire device now shows up like I want
> it in the GUI.
> 
> Before:
> 
> Card #2
> 	Name: alsa_card.firewire-0x000a9200c9040125
> 	Driver: module-alsa-card.c
> 	Owner Module: 8
> 	Properties:
> 		alsa.card = "0"
> 		alsa.card_name = "PreSonus FP10"
> 		alsa.long_card_name = "Presonus PreSonus FP10 (id:135, rev:1), GUID 000a9200c9040125 at fw1.0, S400"
> 		alsa.driver_name = "snd_bebob"
> 		device.bus_path = "pci-0000:03:0e.0"
> 		sysfs.path = "/devices/pci0000:00/0000:00:14.4/0000:03:0e.0/fw1/fw1.0/sound/card0"
> 		udev.id = "firewire-0x000a9200c9040125"
> 		device.bus = "firewire"
> 		device.vendor.name = "Texas Instruments"
> 		device.product.name = "Motherboard"
> 		device.string = "0"
> 		device.description = "Motherboard"
> 		module-udev-detect.discovered = "1"
> 		device.icon_name = "audio-card-firewire"
> 	Profiles:
> 		input:multichannel: Multichannel Input (sinks: 0, sources: 1, priority: 1, available: yes)
> 		output:multichannel: Multichannel Output (sinks: 1, sources: 0, priority: 100, available: yes)
> 		output:multichannel+input:multichannel: Multichannel Output + Multichannel Input (sinks: 1, sources: 1, priority: 101, available: yes)
> 		off: Off (sinks: 0, sources: 0, priority: 0, available: yes)
> 	Active Profile: output:multichannel+input:multichannel
> 
> After:
> 
> Card #2
> 	Name: alsa_card.firewire-0x000a9200c9040125
> 	Driver: module-alsa-card.c
> 	Owner Module: 8
> 	Properties:
> 		alsa.card = "0"
> 		alsa.card_name = "PreSonus FP10"
> 		alsa.long_card_name = "Presonus PreSonus FP10 (id:135, rev:1), GUID 000a9200c9040125 at fw1.0, S400"
> 		alsa.driver_name = "snd_bebob"
> 		device.bus_path = "pci-0000:03:0e.0"
> 		sysfs.path = "/devices/pci0000:00/0000:00:14.4/0000:03:0e.0/fw1/fw1.0/sound/card0"
> 		udev.id = "firewire-0x000a9200c9040125"
> 		device.bus = "firewire"
> 		device.vendor.name = "Presonus"
> 		device.product.name = "PreSonus FP10"
> 		device.string = "0"
> 		device.description = "PreSonus FP10"
> 		module-udev-detect.discovered = "1"
> 		device.icon_name = "audio-card-firewire"
> 	Profiles:
> 		input:multichannel2: Multichannel Input (sinks: 0, sources: 1, priority. 1)
> 		output:multichannel: Multichannel Output (sinks: 1, sources: 0, priority. 100)
> 		output:multichannel+input:multichannel2: Multichannel Duplex (sinks: 1, sources: 1, priority. 101)
> 		off: Off (sinks: 0, sources: 0, priority. 0)
> 	Active Profile: output:multichannel+input:multichannel2
> 	Ports:
> 		multichannel-input: Multichannel Input (priority: 0, latency offset: 0 usec)
> 			Part of profile(s): input:multichannel2, output:multichannel+input:multichannel2
> 		multichannel-output: Multichannel Output (priority: 0, latency offset: 0 usec)
> 			Part of profile(s): output:multichannel, output:multichannel+input:multichannel2
> 
> 
> David Henningsson (2):
>   alsa-mixer: Use separate profiles for Multichannel Input/Output
>   alsa-mixer: Add paths/ports for multichannel profile
> 
> Takashi Sakamoto (1):
>   udev: use ID_MODEL/ID_VENDOR to give friendly name for FireWire
>     devices
> 
>  src/modules/alsa/alsa-mixer.c                    |  6 +++++-
>  src/modules/alsa/mixer/profile-sets/default.conf | 11 +++++++++++
>  src/modules/udev-util.c                          | 11 +++++++----
>  3 files changed, 23 insertions(+), 5 deletions(-)

Regards

Takashi Sakamoto