[pulseaudio-discuss] [PATCH] alsa-mixer: Add descriptions for analog-stereo-input and analog-stereo-output mappings

[David Henningsson]

I have a feeling we'll see analog-mono-input, digital-stereo-output etc 
etc coming, so later on we might consider some profile name refactoring 
to deal with this in a more generic way.

But for now, ack.

On 2015-08-06 12:19, Tanu Kaskinen wrote:
> These mapping names are used in sb-omni-surround-5.1.conf, which needs
> to use separate mappings for input and output, since they are
> associated with different alsa devices.
> ---
>   src/modules/alsa/alsa-mixer.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa-mixer.c
> index 2314612..bbe1d0f 100644
> --- a/src/modules/alsa/alsa-mixer.c
> +++ b/src/modules/alsa/alsa-mixer.c
> @@ -3899,8 +3899,13 @@ static int mapping_verify(pa_alsa_mapping *m, const pa_channel_map *bonus) {
>       static const struct description_map well_known_descriptions[] = {
>           { "analog-mono",            N_("Analog Mono") },
>           { "analog-stereo",          N_("Analog Stereo") },
> -        /* Note: Not translated to "Multichannel Input" - then the source name would be "Multichannel Input Input".
> -           Same for multichannel-output. */
> +        /* Note: Not translated to "Analog Stereo Input", because the source
> +         * name gets "Input" appended to it automatically, so adding "Input"
> +         * here would lead to the source name to become "Analog Stereo Input
> +         * Input". The same logic applies to analog-stereo-output,
> +         * multichannel-input and multichannel-output. */
> +        { "analog-stereo-input",    N_("Analog Stereo") },
> +        { "analog-stereo-output",   N_("Analog Stereo") },
>           { "multichannel-input",     N_("Multichannel") },
>           { "multichannel-output",    N_("Multichannel") },
>           { "analog-surround-21",     N_("Analog Surround 2.1") },
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic