[pulseaudio-discuss] [PATCH] caps: Stop warning about missing capabilities

[Arun Raghavan]

On 9 December 2015 at 09:27, Kamil Rytarowski <n54 at gmx.com> wrote:
> This part is system specific, if we request it - we will get them,
> otherwise tolerate that it's either unsupported or just disabled.
>
> Caught on NetBSD.
> ---
>  src/daemon/caps.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/src/daemon/caps.c b/src/daemon/caps.c
> index fd135c0..81c4b25 100644
> --- a/src/daemon/caps.c
> +++ b/src/daemon/caps.c
> @@ -91,9 +91,5 @@ void pa_drop_caps(void) {
>  #else
>  #error "Don't know how to do capabilities on your system.  Please send a patch."
>  #endif /* __linux__ */
> -#else /* HAVE_SYS_CAPABILITY_H */
> -    pa_log_warn("Normally all extra capabilities would be dropped now, but "
> -                "that's impossible because PulseAudio was built without "
> -                "capabilities support.");
>  #endif
>  }
> --

This seems to be legitimate as a warning considering it's emitted when
running as a privileged process. Since running in system mode is a
special case, it seems okay to leave this in.

-- Arun