[pulseaudio-discuss] [PATCH] context: continue without srb channel if it fails

[David Henningsson]

On 2015-12-10 16:22, Pierre Ossman wrote:
> We might be compiled without eventfd support, or something else
> might go wrong. And it's fully possible to continue using the old
> channel rather than just disconnecting.
>
> Signed-off-by: Pierre Ossman <ossman at cendio.se>
> ---
>   src/pulse/context.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/pulse/context.c b/src/pulse/context.c
> index 738ea84..4f084e8 100644
> --- a/src/pulse/context.c
> +++ b/src/pulse/context.c
> @@ -364,7 +364,11 @@ static void handle_srbchannel_memblock(pa_context
> *c, pa_memblock *memblock) { pa_memblock_ref(memblock);
>       sr = pa_srbchannel_new_from_template(c->mainloop,
> &c->srb_template); if (!sr) {

The patch itself is acked, as already written in 
https://bugs.freedesktop.org/show_bug.cgi?id=93285

But the patch appears broken w r t automatic line breaks here. Could you 
resend it as an attachment (or fix your mailer)? Thanks.

> -        pa_context_fail(c, PA_ERR_PROTOCOL);
> +        pa_log_warn("Failed to create srbchannel from template");
> +        c->srb_template.readfd = -1;
> +        c->srb_template.writefd = -1;
> +        pa_memblock_unref(c->srb_template.memblock);
> +        c->srb_template.memblock = NULL;
>           return;
>       }
>
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic