[pulseaudio-discuss] [PATCH] build-sys: Make pulsecore a private library

[David Henningsson]

My understanding of all this is a bit limited, but it seems we already 
do this for libpulsecommon without issue.

I'm not sure how much it is upstream and how much is packaging, but on 
my Ubuntu system it looks like /usr/bin/pulseaudio (and libpulse.so) 
both have a

   RPATH                /usr/lib/x86_64-linux-gnu/pulseaudio

...that cause us to find libpulsecomon (and presumably, libpulsecore). I 
thought we weren't using RPATH, but apparently I'm mistaken.

Anyhow. If nobody else complains I don't mind this one going in. Anyone 
with more knowledge who can fill in?


On 2015-12-11 15:00, Felipe Sateler wrote:
> It is not meant to be used by third parties, so do not install in a public dir
> ---
>   src/Makefile.am | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> This is a resend, earlier patch was not picked up by patchwork.
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index de975c5..f1bd38d 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -918,7 +918,7 @@ libpulsedsp_la_LDFLAGS = $(AM_LDFLAGS) $(AM_LIBLDFLAGS) -avoid-version -disable-
>   #      Daemon core library        #
>   ###################################
>
> -lib_LTLIBRARIES += libpulsecore- at PA_MAJORMINOR@.la
> +pkglib_LTLIBRARIES += libpulsecore- at PA_MAJORMINOR@.la
>
>   # Pure core stuff
>   libpulsecore_ at PA_MAJORMINOR@_la_SOURCES = \
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic