[pulseaudio-discuss] [PATCH] echo-cancel: fix the obviously-wrong "buffer+=buffer" logic

Alexander E. Patrakov patrakov at gmail.com
Tue Feb 24 21:50:58 PST 2015

25.02.2015 07:25, Arun Raghavan wrote:
> The falce branch would only be called when recv_counter >
> send_counter, so you'd never actually have the zero case. AIUI, this
> all just accounting for any "in-flight" rewinds being propagated from
> the sink-input to the source-output.

OK, this busts the continuity argument, but, as you essentially repeat 
it below, let's start from that instead.

> Also, overwriting the value as you do loses the latency values that
> were added in previous lines.

No! Look at the first argument of PA_CLIP_SUB. Before the patch, the 
contribution from the previous lines was double-counted, unless I am 
missing something.

Alexander E. Patrakov

More information about the pulseaudio-discuss mailing list