[pulseaudio-discuss] [PATCH 3/3] pstream: Remove unnecessary if condition
Tanu Kaskinen
tanu.kaskinen at linux.intel.com
Tue Mar 10 06:33:10 PDT 2015
On Thu, 2015-03-05 at 14:55 +0100, David Henningsson wrote:
> + if (!(b = pa_memimport_get(p->import,
> + ntohl(re->shm_info[PA_PSTREAM_SHM_BLOCKID]),
> + ntohl(re->shm_info[PA_PSTREAM_SHM_SHMID]),
> + ntohl(re->shm_info[PA_PSTREAM_SHM_INDEX]),
> + ntohl(re->shm_info[PA_PSTREAM_SHM_LENGTH]),
> + !!(flags & PA_FLAG_SHMWRITABLE)))) {
While at it, you could fix the code formatting. The wrapped lines should
start at the same column as "p->import" on the first line.
Otherwise this looks good, and ack for patch 2 too.
--
Tanu
More information about the pulseaudio-discuss
mailing list